-
Notifications
You must be signed in to change notification settings - Fork 36
bump k8s api #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s api #212
Conversation
fixes devfile/api#1543 |
@Kartikey-star CI check seems to fail on Tried reproducing locally in debug mode as well with no luck:
Also, retried CI check and it still fails, from what I can tell the CI check error is different:
We can open a issue to investigate this. |
FYI @Kartikey-star |
@Kartikey-star could you rebase your PR with the latest changes of the library repo? |
fix for failure coming with #217 FYI @Kartikey-star |
@Kartikey-star Changes are merged, rebase your changes again and the check should pass now. |
Signed-off-by: Kartikey-star <kmamgain@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kartikey-star, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update schema version to 2.2.2 for nodejs test child devfiles (#213) Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add ubuntu server bypass error case for invalid registry urls (#217) Signed-off-by: Michael Valdron <mvaldron@redhat.com> * Fix parent version on test devfile (#216) * Fix parent version on test devfile Signed-off-by: thepetk <thepetk@gmail.com> * Update parent version Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com> * bump k8s api (#212) Signed-off-by: Kartikey-star <kmamgain@redhat.com> * update references to Go 1.21 in docs (#218) Signed-off-by: Michael Valdron <mvaldron@redhat.com> * Add support for 2.3.0 schema version (#219) * updateApi.sh script includes newer schema versions Signed-off-by: Michael Valdron <mvaldron@redhat.com> * devfile 2.3.0 support Signed-off-by: Michael Valdron <mvaldron@redhat.com> * revert schema versions for testing older features Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> * Bump github.com/docker/docker (#221) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.1+incompatible to 25.0.6+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v25.0.1...v25.0.6) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update readme for 2.3.0 schema (#222) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com> Signed-off-by: Kartikey-star <kmamgain@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Co-authored-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Theofanis Petkos <thepetk@gmail.com> Co-authored-by: Kartikey Mamgain <mamgainkartikey@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR is aimed at making the changes required for openshift/console#13816.
The PR to bump the k8s api in devfile api is merged devfile/api#1545.
The current PR makes the required changes for library.
fixes devfile/api#1543